fix(coordinator): kurze Aussetzer machen die Lampe nicht unbedienbar

tests/test_coordinator.py

@@ -2,12 +2,18 @@
 
 from __future__ import annotations
 
+from copy import deepcopy
 from datetime import timedelta
 from unittest.mock import MagicMock
 
 from freezegun.api import FrozenDateTimeFactory
 from homeassistant.components.light import DOMAIN as LIGHT_DOMAIN
-from homeassistant.const import ATTR_ENTITY_ID, SERVICE_TURN_ON, STATE_ON
+from homeassistant.const import (
+    ATTR_ENTITY_ID,
+    SERVICE_TURN_ON,
+    STATE_ON,
+    STATE_UNAVAILABLE,
+)
 from homeassistant.core import HomeAssistant
 from homeassistant.exceptions import HomeAssistantError
 import pytest
@@ -19,6 +25,7 @@ from custom_components.ninlight.api import (
     NinlightRequestError,
 )
 from tests.helpers import entity_id_for
+from tests_unit.samples import STATE_RGB
 
 
 @pytest.mark.parametrize(
@@ -48,6 +55,112 @@ async def test_write_errors_are_translated(
     assert raised.value.translation_placeholders == placeholders
 
 
+async def test_first_and_second_consecutive_poll_failures_keep_lamp_available(
+    hass: HomeAssistant, init_integration, mock_client: MagicMock, freezer: FrozenDateTimeFactory
+) -> None:
+    entity_id = entity_id_for(hass, "light", "light")
+    mock_client.get_state.side_effect = NinlightConnectionError("down")
+
+    reads = mock_client.get_state.await_count
+    freezer.tick(timedelta(seconds=31))
+    async_fire_time_changed(hass)
+    await hass.async_block_till_done()
+    assert mock_client.get_state.await_count == reads + 1
+    assert hass.states.get(entity_id).state == STATE_ON
+
+    freezer.tick(timedelta(seconds=31))
+    async_fire_time_changed(hass)
+    await hass.async_block_till_done()
+    assert mock_client.get_state.await_count == reads + 2
+    assert hass.states.get(entity_id).state == STATE_ON
+
+
+async def test_third_consecutive_poll_failure_makes_lamp_unavailable(
+    hass: HomeAssistant, init_integration, mock_client: MagicMock, freezer: FrozenDateTimeFactory
+) -> None:
+    entity_id = entity_id_for(hass, "light", "light")
+    mock_client.get_state.side_effect = NinlightConnectionError("down")
+
+    for _ in range(3):
+        freezer.tick(timedelta(seconds=31))
+        async_fire_time_changed(hass)
+        await hass.async_block_till_done()
+
+    assert hass.states.get(entity_id).state == STATE_UNAVAILABLE
+
+
+async def test_successful_poll_resets_failure_counter(
+    hass: HomeAssistant, init_integration, mock_client: MagicMock, freezer: FrozenDateTimeFactory
+) -> None:
+    entity_id = entity_id_for(hass, "light", "light")
+    mock_client.get_state.side_effect = NinlightConnectionError("down")
+
+    # Two failures tolerated.
+    for _ in range(2):
+        freezer.tick(timedelta(seconds=31))
+        async_fire_time_changed(hass)
+        await hass.async_block_till_done()
+    assert hass.states.get(entity_id).state == STATE_ON
+
+    # A successful poll resets the counter.
+    mock_client.get_state.side_effect = lambda: deepcopy(STATE_RGB)
+    freezer.tick(timedelta(seconds=31))
+    async_fire_time_changed(hass)
+    await hass.async_block_till_done()
+    assert hass.states.get(entity_id).state == STATE_ON
+
+    # Two more failures in a row must still be tolerated.
+    mock_client.get_state.side_effect = NinlightConnectionError("down")
+    for _ in range(2):
+        freezer.tick(timedelta(seconds=31))
+        async_fire_time_changed(hass)
+        await hass.async_block_till_done()
+    assert hass.states.get(entity_id).state == STATE_ON
+
+
+async def test_turn_on_reaches_lamp_during_a_tolerated_poll_failure(
+    hass: HomeAssistant, init_integration, mock_client: MagicMock, freezer: FrozenDateTimeFactory
+) -> None:
+    entity_id = entity_id_for(hass, "light", "light")
+    mock_client.get_state.side_effect = NinlightConnectionError("down")
+
+    freezer.tick(timedelta(seconds=31))
+    async_fire_time_changed(hass)
+    await hass.async_block_till_done()
+    assert hass.states.get(entity_id).state == STATE_ON
+
+    await hass.services.async_call(
+        LIGHT_DOMAIN,
+        SERVICE_TURN_ON,
+        {ATTR_ENTITY_ID: entity_id},
+        blocking=True,
+    )
+    mock_client.set_state.assert_awaited_with(on=True)
+
+
+async def test_successful_write_makes_unavailable_lamp_available_again(
+    hass: HomeAssistant, init_integration, mock_client: MagicMock, freezer: FrozenDateTimeFactory
+) -> None:
+    entity_id = entity_id_for(hass, "light", "light")
+    mock_client.get_state.side_effect = NinlightConnectionError("down")
+
+    for _ in range(3):
+        freezer.tick(timedelta(seconds=31))
+        async_fire_time_changed(hass)
+        await hass.async_block_till_done()
+    assert hass.states.get(entity_id).state == STATE_UNAVAILABLE
+
+    await init_integration.runtime_data.async_set_state(on=True)
+    await hass.async_block_till_done()
+    assert hass.states.get(entity_id).state != STATE_UNAVAILABLE
+
+    # The counter was reset by the write: one more failure must still be tolerated.
+    freezer.tick(timedelta(seconds=31))
+    async_fire_time_changed(hass)
+    await hass.async_block_till_done()
+    assert hass.states.get(entity_id).state != STATE_UNAVAILABLE
+
+
 async def test_polling_pauses_while_an_update_runs(
     hass: HomeAssistant, init_integration, mock_client: MagicMock, freezer: FrozenDateTimeFactory
 ) -> None:

tests/test_light.py

@@ -200,9 +200,10 @@ async def test_unreachable_lamp_becomes_unavailable_and_recovers(
 ) -> None:
     entity_id = entity_id_for(hass, "light", "light")
     mock_client.get_state.side_effect = NinlightConnectionError("down")
-    freezer.tick(timedelta(seconds=31))
-    async_fire_time_changed(hass)
-    await hass.async_block_till_done()
+    for _ in range(3):
+        freezer.tick(timedelta(seconds=31))
+        async_fire_time_changed(hass)
+        await hass.async_block_till_done()
     assert hass.states.get(entity_id).state == STATE_UNAVAILABLE
 
     mock_client.get_state.side_effect = lambda: deepcopy(STATE_RGB)